[PATCH v2 01/14] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions
kw at linux.com
Tue May 18 03:44:33 AEST 2021
> > The sysfs_emit() and sysfs_emit_at() functions were introduced to make
> > it less ambiguous which function is preferred when writing to the output
> > buffer in a device attribute's "show" callback .
> > Convert the PCI sysfs object "show" functions from sprintf(), snprintf()
> > and scnprintf() to sysfs_emit() and sysfs_emit_at() accordingly, as the
> > latter is aware of the PAGE_SIZE buffer and correctly returns the number
> > of bytes written into the buffer.
> > No functional change intended.
> >  Documentation/filesystems/sysfs.rst
> > Related to:
> > commit ad025f8e46f3 ("PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in "show" functions")
> I re-reviewed the whole series. It still looks good to me.
> Very nice solution in patch 12 to the new line issue.
> Reviewed-by: Logan Gunthorpe <logang at deltatee.com>
I will send v3 incorporating the style change as per Joe's suggestion
and carry-over your "Reviewed-by", if you don't mind, as it will be
a trivial change.
More information about the Linuxppc-dev