[PATCH v2 04/14] PCI/MSI: Use sysfs_emit() and sysfs_emit_at() in "show" functions
Krzysztof Wilczyński
kw at linux.com
Sat May 15 16:01:10 AEST 2021
Hi Joe,
[...]
> > if (entry)
> > - return sprintf(buf, "%s\n",
> > - entry->msi_attrib.is_msix ? "msix" : "msi");
> > + return sysfs_emit(buf, "%s\n",
> > + entry->msi_attrib.is_msix ? "msix" : "msi");
> >
> >
> > return -ENODEV;
> > }
>
> trivia: reversing the test would be more common style
>
> if (!entry)
> return -ENODEV;
>
> return sysfs_emit(...);
> }
Excellent point. I will send v3 later that includes this style change.
Thank you!
Krzysztof
More information about the Linuxppc-dev
mailing list