[PATCH 01/11] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions

Krzysztof Wilczyński kw at linux.com
Thu May 13 22:49:46 AEST 2021

Hi Logan,

> Thanks, this is a great cleanup. I've reviewed the entire series.
> Reviewed-by: Logan Gunthorpe <logang at deltatee.com>

Thank you!  Appreciate it!

> I agree that the new lines that are missing should be added.

While working on the simple change to add the missing new lines, I've
found that we have slight inconsistency with handling these in one of
the attributes, as per:

  # uname -r
  # grep -oE 'pci=resource_alignment.+' /proc/cmdline 
  pci=resource_alignment=20 at 00:1f.2

  # cat /sys/bus/pci/resource_alignment
  20 at 00:1f.
  # echo 20 at 00:1f.2 > /sys/bus/pci/resource_alignment
  # cat /sys/bus/pci/resource_alignment
  20 at 00:1f.2

  # echo -n 20 at 00:1f.2 > /sys/bus/pci/resource_alignment
  # cat /sys/bus/pci/resource_alignment
  20 at 00:1f.

I adjusted the code so that we handle the input better in the upcoming
v2 - the change is simple, but since it adds more code, I'll drop your
"Reviewed-by", so that we can make sure that subsequent review will
cover this new change.  Sorry for troubles in advance!


More information about the Linuxppc-dev mailing list