[PATCH 01/11] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions
Krzysztof Wilczyński
kw at linux.com
Mon May 10 20:30:12 AEST 2021
[+cc Joe for visibility]
[...]
> spin_lock(&resource_alignment_lock);
> if (resource_alignment_param)
> - count = scnprintf(buf, PAGE_SIZE, "%s", resource_alignment_param);
> + count = sysfs_emit(buf, "%s", resource_alignment_param);
> spin_unlock(&resource_alignment_lock);
Following the work that Joe did recently, see:
https://lore.kernel.org/lkml/aa1819fa5faf786573df298e5e2e7d357ba7d4ad.camel@perches.com/
I think we ought to also add the missing newline to our sysfs_emit() and
sysfs_emit_at() users, like the one above and the following:
drivers/pci/pci-sysfs.c
540: return sysfs_emit(buf, "%pOF", np);
To keep things correct and consistent.
Bjorn, I can follow-up with a small patch after this one, or send a v2,
or, if that would be OK with you, then you could fix it during merging,
provided you decide to merge things as-is.
Krzysztof
More information about the Linuxppc-dev
mailing list