[PATCH v2 1/1] hotplug-cpu.c: show 'last online CPU' error in dlpar_cpu_offline()
Daniel Axtens
dja at axtens.net
Fri Mar 26 16:24:59 AEDT 2021
Hi Daniel,
Two small nitpicks:
> This patch adds a 'last online' check in dlpar_cpu_offline() to catch
> the 'last online CPU' offline error, eturning a more informative error
^--- s/eturning/returning/;
> + /* device_offline() will return -EBUSY (via cpu_down())
> + * if there is only one CPU left. Check it here to fail
> + * earlier and with a more informative error message,
> + * while also retaining the cpu_add_remove_lock to be sure
> + * that no CPUs are being online/offlined during this
> + * check. */
Checkpatch has a small issue with this comment:
WARNING: Block comments use a trailing */ on a separate line
#50: FILE: arch/powerpc/platforms/pseries/hotplug-cpu.c:279:
+ * check. */
Apart from that, this patch seems sane to me, but I haven't been able to
test it.
Kind regards,
Daniel
More information about the Linuxppc-dev
mailing list