[PATCH] ASoC: fsl_sai: remove reset code from dai_probe

Shengjiu Wang shengjiu.wang at gmail.com
Fri Mar 19 15:10:48 AEDT 2021


Hi Mark

On Tue, Mar 16, 2021 at 9:51 PM Mark Brown <broonie at kernel.org> wrote:
>
> On Tue, Mar 16, 2021 at 01:42:40PM +0000, Viorel Suman wrote:
>
> > To me it makes sense to manage the clocks and reset from the same place.
> > Currently we have the clocks management moved completely into runtime PM
> > fsl_sai_runtime_resume and fsl_sai_runtime_suspend callbacks.
>
> Usually the pattern is to have probe() leave everything powered up then
> let runtime PM power things down if it's enabled, you can often do the
> power up by having an open coded call to the resume callback in probe().

It seems some drivers very depend on runtime PM, if the CONFIG_PM=n,
the drivers should not work.  What's the strategy for this?
Do we need to support both cases, or only one case is also acceptable?

Best regards
Wang Shengjiu


More information about the Linuxppc-dev mailing list