[PATCH 11/11] powerpc/microwatt: Disable interrupts in boot wrapper main program
Michael Ellerman
mpe at ellerman.id.au
Thu Jun 17 14:06:26 AEST 2021
Nicholas Piggin <npiggin at gmail.com> writes:
> Excerpts from Segher Boessenkool's message of June 17, 2021 9:37 am:
>> On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote:
>>> This ensures that we don't get a decrementer interrupt arriving before
>>> we have set up a handler for it.
>>
>> Maybe add a comment saying this is setting MSR[EE]=0 for that? Or do
>> other bits here matter as well?
>
> Hmm, it actually clears MSR[RI] as well.
>
> __hard_irq_disable() is what we want here, unless the MSR[RI] clearing
> is required as well, in which case there is __hard_EE_RI_disable().
But neither of those exist in the boot wrapper (yet).
cheers
More information about the Linuxppc-dev
mailing list