[PATCH v4 03/10] net/ps3_gelic: Format cleanups

Christophe Leroy christophe.leroy at csgroup.eu
Sun Jul 25 01:44:16 AEST 2021


Geoff Levand <geoff at infradead.org> a écrit :

> In an effort to make the PS3 gelic driver easier to maintain, cleanup the
> the driver source file formatting to be more consistent.

Many of your changes in this patch go in the wrong direction.

For instance, you shall not use { } in an if/else sequence with single  
lines in both the if and the else. See  
https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces

In a multiline operation, the argument of the second line must be  
aligned to the matching parenthesis.

Christophe




More information about the Linuxppc-dev mailing list