[PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures

Geoff Levand geoff at infradead.org
Sun Jul 18 08:36:27 AEST 2021


Hi Christophe,

On 7/11/21 7:03 AM, Christophe Leroy wrote:
> 
> Your patch has a lot of cosmetic changes. Several of them are just wrong. The other ones belong to another patch. This patch should focus only on the changes it targets.
> 
> Your patch is way too big and addresses several different topics. Should be split in several patches.
> 
> I suggest you run checkpatch.pl --strict on your patch
> 

Thanks for the review.  I'll create a follow up patch set with
your comments in mind.

-Geoff


More information about the Linuxppc-dev mailing list