[PATCH] powerpc/8xx: export 'cpm_setbrg' for modules

[Christophe Leroy]

Le 22/01/2021 à 02:08, Randy Dunlap a écrit :
> Fix missing export for a loadable module build:
> 
> ERROR: modpost: "cpm_setbrg" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
> 
> Fixes: 4128a89ac80d ("powerpc/8xx: move CPM1 related files from sysdev/ to platforms/8xx")

I don't understand. Before that commit cpm_setbrg() wasn't exported either.

For me, it fixes the commit that brought the capability to build the cpm uart driver as a module, 
that is commit 1da177e4c3f4 ("Linux-2.6.12-rc")

> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Reported-by: kernel test robot <lkp at intel.com>
> Cc: Nick Desaulniers <ndesaulniers at google.com>
> Cc: clang-built-linux at googlegroups.com
> Cc: Andrew Morton <akpm at linux-foundation.org>
> Cc: Christophe Leroy <christophe.leroy at c-s.fr>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Cc: Paul Mackerras <paulus at samba.org>
> Cc: linuxppc-dev at lists.ozlabs.org
> ---
>   arch/powerpc/platforms/8xx/cpm1.c |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- linux-next-20210121.orig/arch/powerpc/platforms/8xx/cpm1.c
> +++ linux-next-20210121/arch/powerpc/platforms/8xx/cpm1.c
> @@ -280,6 +280,7 @@ cpm_setbrg(uint brg, uint rate)
>   		out_be32(bp, (((BRG_UART_CLK_DIV16 / rate) - 1) << 1) |
>   			      CPM_BRG_EN | CPM_BRG_DIV16);
>   }
> +EXPORT_SYMBOL(cpm_setbrg);
>   
>   struct cpm_ioport16 {
>   	__be16 dir, par, odr_sor, dat, intr;
>