[PATCH] powerpc: mpc52xx_gpt: fix a potential memory leak
xkernel.wang at foxmail.com
xkernel.wang at foxmail.com
Mon Dec 13 13:26:41 AEDT 2021
Michael Ellerman <mpe at ellerman.id.au> wrote:
> > When some internal memory errors happend in of_iomap(), we should free
> > gpt to prevent memory leak.
>
> But it's allocated with devm_kzalloc(), so the devres core is meant to
> free it for us isn't it?
Yes, maybe you are right. I did that as I mentioned when gpt-regs is NULL, it
will return -ENOMEM, which is the same when gpt is NULL. So I suppose to
free it in time is better:
> gpt = devm_kzalloc(&ofdev->dev, sizeof *gpt, GFP_KERNEL);
> if (!gpt)
> return -ENOMEM;
cheers
More information about the Linuxppc-dev
mailing list