[PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()
Xianting TIan
xianting.tian at linux.alibaba.com
Fri Aug 13 16:04:02 AEST 2021
在 2021/8/13 下午1:53, Jiri Slaby 写道:
> Hi,
>
> On 12. 08. 21, 14:26, kernel test robot wrote:
>>>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is
>>>> uninitialized when used here [-Wuninitialized]
>> spin_unlock_irqrestore(&hp->c_lock, flags);
>> ^~
>> drivers/tty/hvc/hvc_console.c:149:23: note: initialize the
>> variable 'hp' to silence this warning
>> struct hvc_struct *hp;
>> ^
>> = NULL
>
> So you clearly didn't test your change as it would crash quite
> instantly. I wonder, where do you intend to get hp from in the
> console::print() hook?
I am very sorry for the inconvenience caused.
This is caused by my carelessness:(
I take it for granted that there is no problem when I just switch to use
array(cons_outbuf[]).
sorry agin.
>
> thanks,
More information about the Linuxppc-dev
mailing list