[PATCH V2 net] ibmvnic: Continue with reset if set link down failed

Rick Lindsley ricklind at linux.vnet.ibm.com
Fri Apr 23 12:26:24 AEST 2021


On 4/22/21 10:21 AM, Michal Suchánek wrote:

> Merging do_reset and do_hard_reset might be a good code cleanup which is
> out of the scope of this fix.

I agree, on both points. Accepting the patch, and improving the reset
path are not in conflict with each other.

My position is that improving the reset path is certainly on the table,
but not with this bug or this fix.  Within the context of this discovered
problem, the issue is well understood, the fix is small and addresses the
immediate problem, and it has not generated new bugs under subsequent
testing.  For those reasons, the submitted patch has my support.

Rick



More information about the Linuxppc-dev mailing list