[PATCH 06/18] iommu/fsl_pamu: remove ->domain_window_enable
Christoph Hellwig
hch at lst.de
Thu Apr 1 20:32:01 AEDT 2021
On Tue, Mar 30, 2021 at 01:40:09PM +0100, Will Deacon wrote:
> > + ret = pamu_config_ppaace(liodn, geom->aperture_start,
> > + geom->aperture_end - 1, ~(u32)0,
>
> You're passing 'geom->aperture_end - 1' as the size here, but the old code
> seemed to _add_ 1:
>
> > - win_size = (domain->geometry.aperture_end + 1) >> ilog2(1);
>
> here ^^ when calculating the exclusive upper bound. In other words, I think
> '1ULL << 36' used to get passed to pamu_config_ppaace(). Is that an
> intentional change?
No, I've fixed it up.
More information about the Linuxppc-dev
mailing list