[PATCH v2 6/7] powerpc/perf: Remove unused variable 'target' in trace_imc_event_init()

Athira Rajeev atrajeev at linux.vnet.ibm.com
Thu Sep 17 22:20:43 AEST 2020



> On 15-Sep-2020, at 2:40 AM, Cédric Le Goater <clg at kaod.org> wrote:
> 
> This fixes a compile error with W=1.
> 
> CC      arch/powerpc/perf/imc-pmu.o
> ../arch/powerpc/perf/imc-pmu.c: In function ‘trace_imc_event_init’:
> ../arch/powerpc/perf/imc-pmu.c:1429:22: error: variable ‘target’ set but not used [-Werror=unused-but-set-variable]
>  struct task_struct *target;
>                      ^~~~~~
> 
> Cc: Anju T Sudhakar <anju at linux.vnet.ibm.com>
> Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
> arch/powerpc/perf/imc-pmu.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c
> index 62d0b54086f8..9ed4fcccf8a9 100644
> --- a/arch/powerpc/perf/imc-pmu.c
> +++ b/arch/powerpc/perf/imc-pmu.c
> @@ -1426,8 +1426,6 @@ static void trace_imc_event_del(struct perf_event *event, int flags)
> 
> static int trace_imc_event_init(struct perf_event *event)
> {
> -	struct task_struct *target;
> -
> 	if (event->attr.type != event->pmu->type)
> 		return -ENOENT;
> 
> @@ -1458,7 +1456,6 @@ static int trace_imc_event_init(struct perf_event *event)
> 	mutex_unlock(&imc_global_refc.lock);
> 
> 	event->hw.idx = -1;
> -	target = event->hw.target;

Reviewed-by: Athira Rajeev <atrajeev at linux.vnet.ibm.com>

Thanks
Athira
> 
> 	event->pmu->task_ctx_nr = perf_hw_context;
> 	event->destroy = reset_global_refc;
> -- 
> 2.25.4
> 



More information about the Linuxppc-dev mailing list