[PATCH 7/7] powerpc/32: Fix W=1 compile warning

[Christophe Leroy]

Le 10/09/2020 à 23:02, Cédric Le Goater a écrit :
> CC      arch/powerpc/kernel/traps.o
> ../arch/powerpc/kernel/traps.c:1663:6: error: no previous prototype for ‘stack_overflow_exception’ [-Werror=missing-prototypes]
>   void stack_overflow_exception(struct pt_regs *regs)
>        ^~~~~~~~~~~~~~~~~~~~~~~~
> 

A small sentence explaining how this is fixed would be welcome, so that 
you don't need to read the code the know what the commit does to fix the 
warning. Also the subject should be more explicit.


> Cc: Christophe Leroy <christophe.leroy at c-s.fr>

Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>


> Fixes: 3978eb78517c ("powerpc/32: Add early stack overflow detection with VMAP stack.")
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>   arch/powerpc/include/asm/asm-prototypes.h | 1 +

Note that asm-prototypes.h is not the right place for such a prototype, 
but that's probably for another cleanup patch. See discussion at 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1463534212-4879-2-git-send-email-dja@axtens.net/

Christophe


>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/include/asm/asm-prototypes.h b/arch/powerpc/include/asm/asm-prototypes.h
> index de14b1a34d56..4957119604c7 100644
> --- a/arch/powerpc/include/asm/asm-prototypes.h
> +++ b/arch/powerpc/include/asm/asm-prototypes.h
> @@ -67,6 +67,7 @@ void single_step_exception(struct pt_regs *regs);
>   void program_check_exception(struct pt_regs *regs);
>   void alignment_exception(struct pt_regs *regs);
>   void StackOverflow(struct pt_regs *regs);
> +void stack_overflow_exception(struct pt_regs *regs);
>   void kernel_fp_unavailable_exception(struct pt_regs *regs);
>   void altivec_unavailable_exception(struct pt_regs *regs);
>   void vsx_unavailable_exception(struct pt_regs *regs);
>