[PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends
David Hildenbrand
david at redhat.com
Wed Sep 9 17:28:55 AEST 2020
On 09.09.20 09:17, Greg Kroah-Hartman wrote:
> On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote:
>> We soon want to pass flags, e.g., to mark added System RAM resources.
>> mergeable. Prepare for that.
>
> What are these random "flags", and how do we know what should be passed
> to them?
>
> Why not make this an enumerated type so that we know it all works
> properly, like the GPF_* flags are? Passing around a random unsigned
> long feels very odd/broken...
Agreed, an enum (mhp_flags) seems to give a better hint what can
actually be passed. Thanks!
--
Thanks,
David / dhildenb
More information about the Linuxppc-dev
mailing list