[PATCH] powerpc/64: Make VDSO32 track COMPAT on 64-bit

Michael Ellerman mpe at ellerman.id.au
Wed Sep 9 09:32:21 AEST 2020


Christophe Leroy <christophe.leroy at csgroup.eu> writes:
> Le 08/09/2020 à 14:58, Michael Ellerman a écrit :
>> When we added the VDSO32 kconfig symbol, which controls building of
>> the 32-bit VDSO, we made it depend on CPU_BIG_ENDIAN (for 64-bit).
>> 
>> That was because back then COMPAT was always enabled for 64-bit, so
>> depending on it would have left the 32-bit VDSO always enabled, which
>> we didn't want.
>> 
>> But since then we have made COMPAT selectable, and off by default for
>> ppc64le, so VDSO32 should really depend on that.
>> 
>> For most people this makes no difference, none of the defconfigs
>> change, it's only if someone is building ppc64le with COMPAT=y, they
>> will now also get VDSO32. If they've enabled COMPAT in order to run
>> 32-bit binaries they presumably also want the 32-bit VDSO.
>> 
>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>
>
> Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>
>
> Michael, please note that christophe.leroy at c-s.fr is a deprecated 
> address that will one day not work anymore. Please use the new one 
> whenever possible.

OK, I had the old one in my ~/.mailrc, fixed now.

cheers


More information about the Linuxppc-dev mailing list