[PATCH] net: ucc_geth: Drop extraneous parentheses in comparison
Jakub Kicinski
kuba at kernel.org
Sat Oct 24 12:45:43 AEDT 2020
On Fri, 23 Oct 2020 14:32:36 +1100 Michael Ellerman wrote:
> Clang warns about the extra parentheses in this comparison:
>
> drivers/net/ethernet/freescale/ucc_geth.c:1361:28:
> warning: equality comparison with extraneous parentheses
> if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII))
> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> It seems clear the intent here is to do a comparison not an
> assignment, so drop the extra parentheses to avoid any confusion.
>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
Applied, thanks!
More information about the Linuxppc-dev
mailing list