[PATCH v2 1/2] genirq: add an irq_create_mapping_affinity() function
Laurent Vivier
lvivier at redhat.com
Thu Nov 26 01:09:42 AEDT 2020
On 25/11/2020 14:20, Thomas Gleixner wrote:
> Laurent,
>
> On Wed, Nov 25 2020 at 12:16, Laurent Vivier wrote:
>
> The proper subsystem prefix is: 'genirq/irqdomain:' and the first letter
> after the colon wants to be uppercase.
Ok.
>> This function adds an affinity parameter to irq_create_mapping().
>> This parameter is needed to pass it to irq_domain_alloc_descs().
>
> A changelog has to explain the WHY. 'The parameter is needed' is not
> really useful information.
>
The reason of this change is explained in PATCH 2.
I have two patches, one to change the interface with no functional change (PATCH 1) and
one to fix the problem (PATCH 2). Moreover they don't cover the same subsystems.
I can either:
- merge the two patches
- or make a reference in the changelog of PATCH 1 to PATCH 2
(something like "(see folowing patch "powerpc/pseries: pass MSI affinity to
irq_create_mapping()")")
- or copy some information from PATCH 2
(something like "this parameter is needed by rtas_setup_msi_irqs() to pass the affinity
to irq_domain_alloc_descs() to fix multiqueue affinity")
What do you prefer?
Thanks,
Laurent
More information about the Linuxppc-dev
mailing list