[PATCH net-next 04/15] net: mlx5: Replace in_irq() usage.

Jakub Kicinski kuba at kernel.org
Sun Nov 1 03:59:38 AEDT 2020


On Tue, 27 Oct 2020 23:54:43 +0100 Sebastian Andrzej Siewior wrote:
> mlx5_eq_async_int() uses in_irq() to decide whether eq::lock needs to be
> acquired and released with spin_[un]lock() or the irq saving/restoring
> variants.
> 
> The usage of in_*() in drivers is phased out and Linus clearly requested
> that code which changes behaviour depending on context should either be
> seperated or the context be conveyed in an argument passed by the caller,
> which usually knows the context.
> 
> mlx5_eq_async_int() knows the context via the action argument already so
> using it for the lock variant decision is a straight forward replacement
> for in_irq().
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Cc: Saeed Mahameed <saeedm at nvidia.com>
> Cc: Leon Romanovsky <leon at kernel.org>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Jakub Kicinski <kuba at kernel.org>
> Cc: linux-rdma at vger.kernel.org

Saeed, please pick this up into your tree.


More information about the Linuxppc-dev mailing list