[PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block

Nicholas Piggin npiggin at gmail.com
Mon Mar 23 12:30:21 AEDT 2020


Haren Myneni's on March 23, 2020 10:57 am:
> On Mon, 2020-03-23 at 10:30 +1000, Nicholas Piggin wrote:
>> Haren Myneni's on March 19, 2020 4:13 pm:
>> > 
>> > Kernel sets fault address and status in CRB for NX page fault on user
>> > space address after processing page fault. User space gets the signal
>> > and handles the fault mentioned in CRB by bringing the page in to
>> > memory and send NX request again.
>> > 
>> > Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
>> > Signed-off-by: Haren Myneni <haren at linux.ibm.com>
>> > ---
>> >  arch/powerpc/include/asm/icswx.h | 18 +++++++++++++++++-
>> >  1 file changed, 17 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/arch/powerpc/include/asm/icswx.h b/arch/powerpc/include/asm/icswx.h
>> > index 9872f85..b233d1e 100644
>> > --- a/arch/powerpc/include/asm/icswx.h
>> > +++ b/arch/powerpc/include/asm/icswx.h
>> 
>> "icswx" is not a thing anymore, after 6ff4d3e96652 ("powerpc: Remove old 
>> unused icswx based coprocessor support"). I guess NX is reusing some 
>> things from it, but it would be good to get rid of the cruft and re-name
>> this file and and relevant names.
>> 
>> NX already uses this file, so I guesss that can happen after this series.
> 
> But NX uses icswx on P8 and icswx.h has only NX specific macros right
> now. 

Oh P8 in kernel is still using it? Ignore me then.

Thanks,
Nick


More information about the Linuxppc-dev mailing list