Re:Re: [PATCH v2] powerpc/fsl-85xx: fix compile error

[王文虎]

发件人：Christophe Leroy <christophe.leroy at c-s.fr>
发送日期：2020-03-14 03:24:20
收件人："王文虎" <wenhu.wang at vivo.com>
抄送人：Benjamin Herrenschmidt <benh at kernel.crashing.org>,Paul Mackerras <paulus at samba.org>,Michael Ellerman <mpe at ellerman.id.au>,Richard Fontana <rfontana at redhat.com>,Kate Stewart <kstewart at linuxfoundation.org>,Allison Randal <allison at lohutok.net>,Thomas Gleixner <tglx at linutronix.de>,linuxppc-dev at lists.ozlabs.org,linux-kernel at vger.kernel.org,kernel at vivo.com,trivial at kernel.org
主题：Re: [PATCH v2] powerpc/fsl-85xx: fix compile error>
>
>Le 13/03/2020 à 19:17, 王文虎 a écrit :
>> 发件人：Christophe Leroy <christophe.leroy at c-s.fr>
>> 发送日期：2020-03-14 01:45:11
>> 收件人：WANG Wenhu <wenhu.wang at vivo.com>,Benjamin Herrenschmidt <benh at kernel.crashing.org>,Paul Mackerras <paulus at samba.org>,Michael Ellerman <mpe at ellerman.id.au>,Richard Fontana <rfontana at redhat.com>,Kate Stewart <kstewart at linuxfoundation.org>,Allison Randal <allison at lohutok.net>,Thomas Gleixner <tglx at linutronix.de>,linuxppc-dev at lists.ozlabs.org,linux-kernel at vger.kernel.org
>> 抄送人：kernel at vivo.com,trivial at kernel.org
>> 主题：Re: [PATCH v2] powerpc/fsl-85xx: fix compile error>
>>>
>>> Le 13/03/2020 à 18:19, WANG Wenhu a écrit :
>>>> Include "linux/of_address.h" to fix the compile error for
>>>> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
>>>>
>>>>     CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
>>>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’:
>>>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration]
>>>>     l2ctlr = of_iomap(dev->dev.of_node, 0);
>>>>              ^~~~~~~~
>>>>              pci_iomap
>>>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>>>     l2ctlr = of_iomap(dev->dev.of_node, 0);
>>>>            ^
>>>> cc1: all warnings being treated as errors
>>>> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
>>>> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>>>>
>>>> Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>>>
>>> Shouldn't you Cc stable as well ?
>> Pretty sure if it makes a difference(that I did not recognize).
>> Does the inconsistency of Cc lead to a failure on classification
>> or something else which may confuse you?
>
>See 
>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.1.9#n299
Seen, and I 'll do a repatch of v3 with stable being added
to sign-off area as Cc list. Thanks a lot.

Wenhu

>
>>>
>>>> Signed-off-by: WANG Wenhu <wenhu.wang at vivo.com>
>>>> ---
>>>
>>> What's the difference between v1 and v2 ?
>> The label field modification: "Fixed" -> "Fixes", which now is
>> identified successfully. Really sorry for the fault on v1.
>
>Ok. Usually people tell here (just below the ---) what is the difference 
>between the different versions. It helps people understand what the 
>changes are.
>
>Christophe