[PATCH v2 net-next] net: convert suitable drivers to use phy_do_ioctl_running

Florian Fainelli f.fainelli at gmail.com
Wed Jan 22 15:04:50 AEDT 2020



On 1/21/2020 1:09 PM, Heiner Kallweit wrote:
> Convert suitable drivers to use new helper phy_do_ioctl_running.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
The vast majority of drivers that you are converting use the following
convention:

- !netif_running -> return -EINVAL
- !dev->phydev -> return -ENODEV

so it may make sense to change the helper to accommodate the majority
here, not that I believe this is going to make much practical
difference, but if there were test cases that were specifically looking
for such an error code, they could be failing after this changeset.

For bgmac.c, bcmgenet.c and cpmac.c:

Acked-by: Florian Fainelli <f.fainelli at gmail.com>

Whether you decide to spin another version or not.
-- 
Florian


More information about the Linuxppc-dev mailing list