Re:Re: [PATCH] powerpc/sysdev: fix compile errors

[王文虎]

发件人：Andrew Donnellan <ajd at linux.ibm.com>
发送日期：2020-01-21 14:13:07
收件人：wangwenhu <wenhu.pku at gmail.com>,Benjamin Herrenschmidt <benh at kernel.crashing.org>,Paul Mackerras <paulus at samba.org>,Michael Ellerman <mpe at ellerman.id.au>,Kate Stewart <kstewart at linuxfoundation.org>,Greg Kroah-Hartman <gregkh at linuxfoundation.org>,Richard Fontana <rfontana at redhat.com>,Thomas Gleixner <tglx at linutronix.de>,linuxppc-dev at lists.ozlabs.org,linux-kernel at vger.kernel.org
抄送人：trivial at kernel.org,lonehugo at hotmail.com,wenhu.wang at vivo.com
主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>> From: wangwenhu <wenhu.wang at vivo.com>
>> 
>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>> fix the implicit declaration compile errors when building Cache-Sram.
>> 
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                            ^~~~~~~~~~~~~~~~
>>                            bitmap_complement
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                          ^
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>    iounmap(cache_sram->base_virt);
>>    ^~~~~~~
>>    roundup
>> cc1: all warnings being treated as errors
>> 
>> Signed-off-by: wangwenhu <wenhu.wang at vivo.com>
>
>How long has this code been broken for?

It's been broken almost 15 months since the commit below:
"commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
Author: Christophe Leroy <christophe.leroy at c-s.fr>
Date:   Tue Oct 9 13:51:41 2018 +0000

    powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."

And we are working on it now for further development.

>
>> ---
>>   arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> index f6c665dac725..29b6868eff7d 100644
>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/of_platform.h>
>>   #include <asm/pgtable.h>
>>   #include <asm/fsl_85xx_cache_sram.h>
>> +#include <asm/io.h>
>> 
>>   #include "fsl_85xx_cache_ctlr.h"
>> 
>
>-- 
>Andrew Donnellan              OzLabs, ADL Canberra
>ajd at linux.ibm.com             IBM Australia Limited
>

Wenhu