[PATCH v2 01/11] powerpc/powernv/ioda: Fix ref count for devices with their own PE

[Andrew Donnellan]

On 9/1/20 1:11 am, Frederic Barrat wrote:
>> It took me a while to parse exactly what you're doing here.
>>
>> - In pnv_ioda_setup_dev_PE(), we take a reference on the pci_dev, this 
>> is to protect a pointer in the pci_dn structure, but not to protect 
>> the pointer in the pci_dev structure (which doesn't need to be 
>> protected by taking a reference, because the lifetime of the 
>> pnv_ioda_pe is the same as the pci_dev).
>>
>> - The pointer in the pci_dn structure has now been removed, so we 
>> should remove the pci_dev_get() accordingly.
> 
> 
> Correct. Did I do such a bad job explaining it in the commit message 
> that I need to rephrase?

I might just be a bit slow :)

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd at linux.ibm.com             IBM Australia Limited