[PATCH] powerpc/mm: Mark get_slice_psize() & slice_addr_is_low() as notrace
Michael Ellerman
patch-notifications at ellerman.id.au
Mon Jan 6 16:23:21 AEDT 2020
On Sat, 2019-12-21 at 12:13:37 UTC, Michael Ellerman wrote:
> These slice routines are called from the SLB miss handler, which can
> lead to warnings from the IRQ code, because we have not reconciled the
> IRQ state properly:
>
> WARNING: CPU: 72 PID: 30150 at arch/powerpc/kernel/irq.c:258 arch_local_irq_restore.part.0+0xcc/0x100
> Modules linked in:
> CPU: 72 PID: 30150 Comm: ftracetest Not tainted 5.5.0-rc2-gcc9x-g7e0165b2f1a9 #1
> NIP: c00000000001d83c LR: c00000000029ab90 CTR: c00000000026cf90
> REGS: c0000007eee3b960 TRAP: 0700 Not tainted (5.5.0-rc2-gcc9x-g7e0165b2f1a9)
> MSR: 8000000000021033 <SF,ME,IR,DR,RI,LE> CR: 22242844 XER: 20000000
> CFAR: c00000000001d780 IRQMASK: 0
> ...
> NIP arch_local_irq_restore.part.0+0xcc/0x100
> LR trace_graph_entry+0x270/0x340
> Call Trace:
> trace_graph_entry+0x254/0x340 (unreliable)
> function_graph_enter+0xe4/0x1a0
> prepare_ftrace_return+0xa0/0x130
> ftrace_graph_caller+0x44/0x94 # (get_slice_psize())
> slb_allocate_user+0x7c/0x100
> do_slb_fault+0xf8/0x300
> instruction_access_slb_common+0x140/0x180
>
> Fixes: 48e7b7695745 ("powerpc/64s/hash: Convert SLB miss handlers to C")
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/91a063c956084fb21cf2523bce6892514e3f1799
cheers
More information about the Linuxppc-dev
mailing list