[PATCH v3 08/15] powerpc: Replace cpu_up/down with add/remove_cpu

Qais Yousef qais.yousef at arm.com
Mon Feb 24 06:29:35 AEDT 2020


The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down a private interface for anything
but the cpu subsystem.

Acked-by: Michael Ellerman <mpe at ellerman.id.au>
Signed-off-by: Qais Yousef <qais.yousef at arm.com>
CC: Benjamin Herrenschmidt <benh at kernel.crashing.org>
CC: Paul Mackerras <paulus at samba.org>
CC: Michael Ellerman <mpe at ellerman.id.au>
CC: Enrico Weigelt <info at metux.net>
CC: Ram Pai <linuxram at us.ibm.com>
CC: Nicholas Piggin <npiggin at gmail.com>
CC: Thiago Jung Bauermann <bauerman at linux.ibm.com>
CC: Christophe Leroy <christophe.leroy at c-s.fr>
CC: Thomas Gleixner <tglx at linutronix.de>
CC: linuxppc-dev at lists.ozlabs.org
CC: linux-kernel at vger.kernel.org
---

Michael, this now uses add_cpu() which you should be CCed on. I wasn't sure if
I can keep your Ack or remove it in this case. Please let me know if you need
more clarification.

 arch/powerpc/kexec/core_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/core_64.c b/arch/powerpc/kexec/core_64.c
index 04a7cba58eff..b4184092172a 100644
--- a/arch/powerpc/kexec/core_64.c
+++ b/arch/powerpc/kexec/core_64.c
@@ -212,7 +212,7 @@ static void wake_offline_cpus(void)
 		if (!cpu_online(cpu)) {
 			printk(KERN_INFO "kexec: Waking offline cpu %d.\n",
 			       cpu);
-			WARN_ON(cpu_up(cpu));
+			WARN_ON(add_cpu(cpu));
 		}
 	}
 }
-- 
2.17.1



More information about the Linuxppc-dev mailing list