[PATCH v2 3/4] libnvdimm/region: Introduce NDD_LABELING

Jeff Moyer jmoyer at redhat.com
Fri Feb 14 06:12:50 AEDT 2020


Dan Williams <dan.j.williams at intel.com> writes:

> @@ -312,8 +312,9 @@ static ssize_t flags_show(struct device *dev,
>  {
>  	struct nvdimm *nvdimm = to_nvdimm(dev);
>  
> -	return sprintf(buf, "%s%s\n",
> +	return sprintf(buf, "%s%s%s\n",
>  			test_bit(NDD_ALIASING, &nvdimm->flags) ? "alias " : "",
> +			test_bit(NDD_LABELING, &nvdimm->flags) ? "label" : "",
                                                                       ^

Missing a space.

The rest looks sane.

Reviewed-by: Jeff Moyer <jmoyer at redhat.com>



More information about the Linuxppc-dev mailing list