[PATCH 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns()

[Christophe Leroy]

Le 21/12/2020 à 08:42, Cédric Le Goater a écrit :
> It fixes W=1 this compile error :

Please give more details on why it can be removed.
Has it been used in the past and its user was removed by a commit ?
Has it never been used ?

> 
> ../arch/powerpc/kernel/optprobes.c:149:6: error: no previous prototype for ‘patch_imm32_load_insns’ [-Werror=missing-prototypes]
>    149 | void patch_imm32_load_insns(unsigned int val, kprobe_opcode_t *addr)
> 
> Cc: Jordan Niethe <jniethe5 at gmail.com>
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>   arch/powerpc/kernel/optprobes.c | 19 -------------------
>   1 file changed, 19 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/optprobes.c b/arch/powerpc/kernel/optprobes.c
> index 69bfe96884e2..da6b88b80ba4 100644
> --- a/arch/powerpc/kernel/optprobes.c
> +++ b/arch/powerpc/kernel/optprobes.c
> @@ -141,25 +141,6 @@ void arch_remove_optimized_kprobe(struct optimized_kprobe *op)
>   	}
>   }
>   
> -/*
> - * emulate_step() requires insn to be emulated as
> - * second parameter. Load register 'r4' with the
> - * instruction.
> - */
> -void patch_imm32_load_insns(unsigned int val, kprobe_opcode_t *addr)
> -{
> -	/* addis r4,0,(insn)@h */
> -	patch_instruction((struct ppc_inst *)addr,
> -			  ppc_inst(PPC_INST_ADDIS | ___PPC_RT(4) |
> -				   ((val >> 16) & 0xffff)));
> -	addr++;
> -
> -	/* ori r4,r4,(insn)@l */
> -	patch_instruction((struct ppc_inst *)addr,
> -			  ppc_inst(PPC_INST_ORI | ___PPC_RA(4) |
> -				   ___PPC_RS(4) | (val & 0xffff)));
> -}
> -
>   /*
>    * Generate instructions to load provided immediate 64-bit value
>    * to register 'reg' and patch these instructions at 'addr'.
>