[PATCH 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static

Christophe Leroy christophe.leroy at csgroup.eu
Mon Dec 21 19:07:17 AEDT 2020



Le 21/12/2020 à 08:42, Cédric Le Goater a écrit :
> It fixes this W=1 compile error:

Explain why it can be made static, not just that it does fix a W=1 compile error,
because there are several possible ways to fix such a warning.

> 
> ../arch/powerpc/platforms/pseries/eeh_pseries.c:46:6: error: no previous prototype for ‘pseries_pcibios_bus_add_device’ [-Werror=missing-prototypes]
>     46 | void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
>        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: dae7253f9f78 ("powerpc/pseries: Add pseries SR-IOV Machine dependent calls")
> Cc: Alexey Kardashevskiy <aik at ozlabs.ru>
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>   arch/powerpc/platforms/pseries/eeh_pseries.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
> index cf024fa37bda..de45ceb634f9 100644
> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
> @@ -43,7 +43,7 @@ static int ibm_get_config_addr_info;
>   static int ibm_get_config_addr_info2;
>   static int ibm_configure_pe;
>   
> -void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
> +static void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
>   {
>   	struct pci_dn *pdn = pci_get_pdn(pdev);
>   
> 


More information about the Linuxppc-dev mailing list