[PATCH 18/20] ethernet: ucc_geth: add helper to replace repeated switch statements

Rasmus Villemoes rasmus.villemoes at prevas.dk
Wed Dec 9 07:55:46 AEDT 2020


On 08/12/2020 16.21, Christophe Leroy wrote:
> 
> 
> Le 05/12/2020 à 20:17, Rasmus Villemoes a écrit :
>> The translation from the ucc_geth_num_of_threads enum value to the
>> actual count can be written somewhat more compactly with a small
>> lookup table, allowing us to replace the four switch statements.
>>
> I think you would allow GCC to provide a much better optimisation with
> something like:
> 

Your version compiles to 120 bytes of object code, mine around 49
(including the 5 byte lookup table). They're about the same in line count.

Rasmus


More information about the Linuxppc-dev mailing list