[PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

Luc Van Oostenryck luc.vanoostenryck at gmail.com
Sat Aug 29 22:45:38 AEST 2020


For ppc32, the functions fsl_ioread64() & fsl_ioread64be()
use lower_32_bits() as a fancy way to cast the pointer to u32
in order to do non-atomic 64-bit IO.

But the pointer is already 32-bit, so simply cast the pointer to u32.

This fixes a compile error introduced by
   ef91bb196b0d ("kernel.h: Silence sparse warning in lower_32_bits")

Fixes: ef91bb196b0db1013ef8705367bc2d7944ef696b
Reported-by: Guenter Roeck <linux at roeck-us.net>
Cc: Li Yang <leoyang.li at nxp.com>
Cc: Zhang Wei <zw at zh-kernel.org>
Cc: Dan Williams <dan.j.williams at intel.com>
Cc: Vinod Koul <vkoul at kernel.org>
Cc: Herbert Xu <herbert at gondor.apana.org.au>
Cc: linuxppc-dev at lists.ozlabs.org
Cc: dmaengine at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck at gmail.com>
---
 drivers/dma/fsldma.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
index 56f18ae99233..6f6fa7641fa2 100644
--- a/drivers/dma/fsldma.h
+++ b/drivers/dma/fsldma.h
@@ -205,7 +205,7 @@ struct fsldma_chan {
 #else
 static u64 fsl_ioread64(const u64 __iomem *addr)
 {
-	u32 fsl_addr = lower_32_bits(addr);
+	u32 fsl_addr = (u32) addr;
 	u64 fsl_addr_hi = (u64)in_le32((u32 *)(fsl_addr + 1)) << 32;
 
 	return fsl_addr_hi | in_le32((u32 *)fsl_addr);
@@ -219,7 +219,7 @@ static void fsl_iowrite64(u64 val, u64 __iomem *addr)
 
 static u64 fsl_ioread64be(const u64 __iomem *addr)
 {
-	u32 fsl_addr = lower_32_bits(addr);
+	u32 fsl_addr = (u32) addr;
 	u64 fsl_addr_hi = (u64)in_be32((u32 *)fsl_addr) << 32;
 
 	return fsl_addr_hi | in_be32((u32 *)(fsl_addr + 1));
-- 
2.28.0



More information about the Linuxppc-dev mailing list