[PATCH v5 4/8] powerpc/watchpoint: Move DAWR detection logic outside of hw_breakpoint.c

[kernel test robot]

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.9-rc2 next-20200826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ravi-Bangoria/powerpc-watchpoint-Bug-fixes-plus-new-feature-flag/20200825-123831
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-r024-20200826 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/hw_breakpoint_constraints.c: In function 'ea_hw_range_overlaps':
>> arch/powerpc/kernel/hw_breakpoint_constraints.c:42:16: error: 'HW_BREAKPOINT_SIZE_QUADWORD' undeclared (first use in this function); did you mean 'HW_BREAKPOINT_SIZE'?
      42 |   align_size = HW_BREAKPOINT_SIZE_QUADWORD;
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                HW_BREAKPOINT_SIZE
   arch/powerpc/kernel/hw_breakpoint_constraints.c:42:16: note: each undeclared identifier is reported only once for each function it appears in

# https://github.com/0day-ci/linux/commit/4899293e6a722214368fd6b5df8ecda43600ccfb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ravi-Bangoria/powerpc-watchpoint-Bug-fixes-plus-new-feature-flag/20200825-123831
git checkout 4899293e6a722214368fd6b5df8ecda43600ccfb
vim +42 arch/powerpc/kernel/hw_breakpoint_constraints.c

    30	
    31	static bool ea_hw_range_overlaps(unsigned long ea, int size,
    32					 struct arch_hw_breakpoint *info)
    33	{
    34		unsigned long hw_start_addr, hw_end_addr;
    35		unsigned long align_size = HW_BREAKPOINT_SIZE;
    36	
    37		/*
    38		 * On p10 predecessors, quadword is handle differently then
    39		 * other instructions.
    40		 */
    41		if (!cpu_has_feature(CPU_FTR_ARCH_31) && size == 16)
  > 42			align_size = HW_BREAKPOINT_SIZE_QUADWORD;
    43	
    44		hw_start_addr = ALIGN_DOWN(info->address, align_size);
    45		hw_end_addr = ALIGN(info->address + info->len, align_size);
    46	
    47		return ((ea < hw_end_addr) && (ea + size > hw_start_addr));
    48	}
    49	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 26958 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20200827/a2c7abcf/attachment-0001.gz>