[PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

Mark Brown broonie at kernel.org
Thu Aug 27 02:53:08 AEST 2020


On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote:
> The function fsl_spdif_probe() is only called with an openfirmware
> platform device. Therefore there is no need to check that the passed
> in device is NULL.

Why is this an issue - the check will make things more robust if someone
manages to load the driver on a non-DT system and otherwise costs us a
couple of instructions?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20200826/813bd9fb/attachment.sig>


More information about the Linuxppc-dev mailing list