[PATCH] powernv/pci: Print an error when device enable is blocked

[Oliver O'Halloran]

On Thu, Apr 9, 2020 at 4:13 PM Oliver O'Halloran <oohall at gmail.com> wrote:
>
> If the platform decides to block enabling the device nothing is printed
> currently. This can lead to some confusion since the dmesg output will
> usually print an error with no context e.g.
>
>         e1000e: probe of 0022:01:00.0 failed with error -22
>
> This shouldn't be spammy since pci_enable_device() already prints a
> messages when it succeeds.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index cda0933..17fdf46 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -3296,8 +3296,10 @@ static bool pnv_pci_enable_device_hook(struct pci_dev *dev)
>                 return true;
>
>         pdn = pci_get_pdn(dev);
> -       if (!pdn || pdn->pe_number == IODA_INVALID_PE)
> +       if (!pdn || pdn->pe_number == IODA_INVALID_PE) {
> +               pci_err("pci_enable_device() blocked, no PE assigned.\n");
Maybe I should start compiling my code before I sent it out. Maybe.

>                 return false;
> +       }
>
>         return true;
>  }
> --
> 2.9.5
>