[PATCH] tty: hvc: remove hvcs_driver_string

Jiri Slaby jslaby at suse.cz
Fri Apr 3 18:30:03 AEDT 2020


On 03. 04. 20, 9:13, Jason Yan wrote:
> No users of hvcs_driver_string, remove it. This fixes the following gcc
> warning:
> 
> drivers/tty/hvc/hvcs.c:199:19: warning: ‘hvcs_driver_string’ defined but
> not used [-Wunused-const-variable=]
>  static const char hvcs_driver_string[]
>                    ^~~~~~~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Jason Yan <yanaijie at huawei.com>

Acked-by: Jiri Slaby <jslaby at suse.cz>

It fixes a commit from 2011:
commit c7704d352d45de47333f2d9f10aead820b49044c
Author: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Date:   Sun Feb 6 18:26:25 2011 +0000

    powerpc/pseries: Reduce HVCS driver insanity
!


> ---
>  drivers/tty/hvc/hvcs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
> index ee0604cd9c6b..55105ac38f89 100644
> --- a/drivers/tty/hvc/hvcs.c
> +++ b/drivers/tty/hvc/hvcs.c
> @@ -196,8 +196,6 @@ module_param(hvcs_parm_num_devs, int, 0);
>  
>  static const char hvcs_driver_name[] = "hvcs";
>  static const char hvcs_device_node[] = "hvcs";
> -static const char hvcs_driver_string[]
> -	= "IBM hvcs (Hypervisor Virtual Console Server) Driver";
>  
>  /* Status of partner info rescan triggered via sysfs. */
>  static int hvcs_rescan_status;
> 


-- 
js
suse labs


More information about the Linuxppc-dev mailing list