[PATCH v2] powerpc/boot: Delete unneeded .globl _zimage_start

Michael Ellerman patch-notifications at ellerman.id.au
Wed Apr 1 23:53:31 AEDT 2020


On Wed, 2020-03-25 at 16:42:57 UTC, Fangrui Song wrote:
> .globl sets the symbol binding to STB_GLOBAL while .weak sets the
> binding to STB_WEAK. GNU as let .weak override .globl since binutils-gdb
> 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang integrated
> assembler let the last win but it may error in the future.
> 
> Since it is a convention that only one binding directive is used, just
> delete .globl.
> 
> Fixes: cd197ffcf10b "[POWERPC] zImage: Cleanup and improve zImage entry point"
> Fixes: ee9d21b3b358 "powerpc/boot: Ensure _zimage_start is a weak symbol"
> Link: https://github.com/ClangBuiltLinux/linux/issues/937
> Signed-off-by: Fangrui Song <maskray at google.com>
> Cc: Alan Modra <amodra at gmail.com>
> Cc: Joel Stanley <joel at jms.id.au>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Nick Desaulniers <ndesaulniers at google.com>
> Cc: Segher Boessenkool <segher at kernel.crashing.org>
> Cc: clang-built-linux at googlegroups.com

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/968339fad422a58312f67718691b717dac45c399

cheers


More information about the Linuxppc-dev mailing list