[PATCH 05/14] powerpc/eeh: Defer printing stack trace

Oliver O'Halloran oohall at gmail.com
Tue Sep 17 13:38:42 AEST 2019


On Tue, Sep 17, 2019 at 1:35 PM Sam Bobroff <sbobroff at linux.ibm.com> wrote:
>
> On Tue, Sep 17, 2019 at 11:45:14AM +1000, Oliver O'Halloran wrote:
> >
> > Two reasons:
> >
> > 1) the eeh_event structures are allocated with GFP_ATOMIC since
> > eeh_dev_check_failure() can be called from any context. Minimising the
> > number of atomic allocations we do is a good idea as a matter of
> > course.
>
> Yes, but I meant directly inside eeh_event so there wouldn't be a second
> allocation. It would just be a bit bigger.

Right, my point was that increasing the allocation size also increases
the chance of an allocation failure.


More information about the Linuxppc-dev mailing list