[PATCH v5 19/31] powerpc/fadump: Update documentation about OPAL platform support

Michael Ellerman mpe at ellerman.id.au
Thu Sep 5 13:15:09 AEST 2019


"Oliver O'Halloran" <oohall at gmail.com> writes:
> On Wed, Sep 4, 2019 at 9:51 PM Michael Ellerman <mpe at ellerman.id.au> wrote:
>> Hari Bathini <hbathini at linux.ibm.com> writes:
...
>> > diff --git a/Documentation/powerpc/firmware-assisted-dump.rst b/Documentation/powerpc/firmware-assisted-dump.rst
>> > index d912755..2c3342c 100644
>> > --- a/Documentation/powerpc/firmware-assisted-dump.rst
>> > +++ b/Documentation/powerpc/firmware-assisted-dump.rst
>> > @@ -96,7 +97,9 @@ as follows:
>> >
>> >  Please note that the firmware-assisted dump feature
>> >  is only available on Power6 and above systems with recent
>> > -firmware versions.
>>
>> Notice how "recent" has bit rotted.
>>
>> > +firmware versions on PSeries (PowerVM) platform and Power9
>> > +and above systems with recent firmware versions on PowerNV
>> > +(OPAL) platform.
>>
>> Can we say something more helpful here, ie. "recent" is not very useful.
>> AFAIK it's actually wrong, there isn't a released firmware with the
>> support yet at all, right?
>>
>> Given all the relevant firmware is open source can't we at least point
>> to a commit or release tag or something?
>
> Even if we can quote a git sha it's not terrible useful or user
> friendly. We already gate the feature behind DT nodes / properties
> existing, so why not just say "fadump requires XYZ firmware feature,
> as indicated by <ABC> device-tree property."

But how does that help someone who's got a Talos/Blackbird and wants to
test this stuff?

cheers


More information about the Linuxppc-dev mailing list