[PATCH] powerpc/tools: Don't quote $objdump in scripts
Segher Boessenkool
segher at kernel.crashing.org
Thu Oct 31 10:27:32 AEDT 2019
On Wed, Oct 30, 2019 at 10:55:03PM +1100, Michael Ellerman wrote:
> Segher Boessenkool <segher at kernel.crashing.org> writes:
> > On Thu, Oct 24, 2019 at 11:47:30AM +1100, Michael Ellerman wrote:
> >> Some of our scripts are passed $objdump and then call it as
> >> "$objdump". This doesn't work if it contains spaces because we're
> >> using ccache, for example you get errors such as:
> >>
> >> ./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory
> >> ./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory
> >>
> >> Fix it by not quoting the string when we expand it, allowing the shell
> >> to do the right thing for us.
> >
> > This breaks things for people with spaces in their paths.
>
> Spaces in their what? Who does that? :)
I know, right?
> Also we don't support it:
>
> $ pwd
> $ /home/michael/foo bar
> $ make clean
> Makefile:147: *** source directory cannot contain spaces or colons. Stop.
Of course. But it's shell scripting 101 that you *do* quote all variable
expansions. Do you want to set a bad example? ;-)
Segher
More information about the Linuxppc-dev
mailing list