[PATCH v2 0/3] crypto: powerpc - convert SPE AES algorithms to skcipher API
Eric Biggers
ebiggers at kernel.org
Tue Oct 15 13:45:14 AEDT 2019
This series converts the glue code for the PowerPC SPE implementations
of AES-ECB, AES-CBC, AES-CTR, and AES-XTS from the deprecated
"blkcipher" API to the "skcipher" API. This is needed in order for the
blkcipher API to be removed.
Patch 1-2 are fixes. Patch 3 is the actual conversion.
Tested with:
export ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu-
make mpc85xx_defconfig
cat >> .config << EOF
# CONFIG_MODULES is not set
# CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
CONFIG_DEBUG_KERNEL=y
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
CONFIG_CRYPTO_AES=y
CONFIG_CRYPTO_CBC=y
CONFIG_CRYPTO_CTR=y
CONFIG_CRYPTO_ECB=y
CONFIG_CRYPTO_XTS=y
CONFIG_CRYPTO_AES_PPC_SPE=y
EOF
make olddefconfig
make -j32
qemu-system-ppc -M mpc8544ds -cpu e500 -nographic \
-kernel arch/powerpc/boot/zImage \
-append cryptomgr.fuzz_iterations=1000
Note that xts-ppc-spe still fails the comparison tests due to the lack
of ciphertext stealing support. This is not addressed by this series.
Changed since v1:
- Split fixes into separate patches.
- Made ppc_aes_setkey_skcipher() call ppc_aes_setkey(), rather than
creating a separate expand_key() function. This keeps the code
shorter.
Eric Biggers (3):
crypto: powerpc - don't unnecessarily use atomic scatterwalk
crypto: powerpc - don't set ivsize for AES-ECB
crypto: powerpc - convert SPE AES algorithms to skcipher API
arch/powerpc/crypto/aes-spe-glue.c | 389 ++++++++++++-----------------
crypto/Kconfig | 1 +
2 files changed, 166 insertions(+), 224 deletions(-)
--
2.23.0
More information about the Linuxppc-dev
mailing list