[PATCH v2 06/14] powerpc: Replace cpu_up/down with device_online/offline
Qais Yousef
qais.yousef at arm.com
Mon Nov 25 22:27:46 AEDT 2019
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.
See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.
This also prepares to make cpu_up/down a private interface for anything
but the cpu subsystem.
Acked-by: Michael Ellerman <mpe at ellerman.id.au>
Signed-off-by: Qais Yousef <qais.yousef at arm.com>
CC: Benjamin Herrenschmidt <benh at kernel.crashing.org>
CC: Paul Mackerras <paulus at samba.org>
CC: Michael Ellerman <mpe at ellerman.id.au>
CC: Enrico Weigelt <info at metux.net>
CC: Ram Pai <linuxram at us.ibm.com>
CC: Nicholas Piggin <npiggin at gmail.com>
CC: Thiago Jung Bauermann <bauerman at linux.ibm.com>
CC: Christophe Leroy <christophe.leroy at c-s.fr>
CC: Thomas Gleixner <tglx at linutronix.de>
CC: linuxppc-dev at lists.ozlabs.org
CC: linux-kernel at vger.kernel.org
---
arch/powerpc/kernel/machine_kexec_64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
index 04a7cba58eff..ebf8cc7acc4d 100644
--- a/arch/powerpc/kernel/machine_kexec_64.c
+++ b/arch/powerpc/kernel/machine_kexec_64.c
@@ -208,13 +208,15 @@ static void wake_offline_cpus(void)
{
int cpu = 0;
+ lock_device_hotplug();
for_each_present_cpu(cpu) {
if (!cpu_online(cpu)) {
printk(KERN_INFO "kexec: Waking offline cpu %d.\n",
cpu);
- WARN_ON(cpu_up(cpu));
+ WARN_ON(device_online(get_cpu_device(cpu)));
}
}
+ unlock_device_hotplug();
}
static void kexec_prepare_cpus(void)
--
2.17.1
More information about the Linuxppc-dev
mailing list