[PATCH] of: unittest: fix memory leak in attach_node_and_children

[Tyrel Datwyler]

On 11/14/19 10:43 AM, Erhard Furtner wrote:
> In attach_node_and_children memory is allocated for full_name via
> kasprintf. If the condition of the 1st if is not met the function
> returns early without freeing the memory. Add a kfree() to fix that.
> 
> Signed-off-by: Erhard Furtner <erhard_f at mailbox.org>

Michael provided instructions about what needs to be done with a v2 spin of your
patch to get it upstream. Please feel free to include my reviewed-by as well.

Reviewed-by: Tyrel Datwyler <tyreld at linux.ibm.com>

> ---
>  drivers/of/unittest.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 92e895d86458..ca7823eef2b4 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1146,8 +1146,10 @@ static void attach_node_and_children(struct device_node *np)
>  	full_name = kasprintf(GFP_KERNEL, "%pOF", np);
> 
>  	if (!strcmp(full_name, "/__local_fixups__") ||
> -	    !strcmp(full_name, "/__fixups__"))
> +	    !strcmp(full_name, "/__fixups__")) {
> +		kfree(full_name);
>  		return;
> +	}
> 
>  	dup = of_find_node_by_path(full_name);
>  	kfree(full_name);
>