[PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

Timur Tabi timur at kernel.org
Fri Nov 15 00:57:12 AEDT 2019


On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
<linux at rasmusvillemoes.dk> wrote:
>
> -       if (*iprop)
> -               qe_port->port.uartclk = *iprop;
> +       if (val)
> +               qe_port->port.uartclk = val;
>         else {
>                 /*
>                  * Older versions of U-Boot do not initialize the brg-frequency
>                  * property, so in this case we assume the BRG frequency is
>                  * half the QE bus frequency.
>                  */

This bug in older U-Boots is definitely PowerPC-specific, so could you
change this so that it reports an error on ARM if brg-frequency is
zero, and displays a warning on PowerPC?


More information about the Linuxppc-dev mailing list