[PATCH v2 09/16] powernv/fadump: process architected register state data provided by firmware

Hari Bathini hbathini at linux.ibm.com
Thu May 9 14:42:42 AEST 2019


On 07/05/19 9:30 PM, Segher Boessenkool wrote:
> On Tue, May 07, 2019 at 07:43:56PM +0530, Mahesh J Salgaonkar wrote:
>> Can we use SPRN_* #defines which are already present in asm/reg.h instead of
>> hard coding numbers for switch cases ? You may want to add new #defines
>> for NIP, MSR and CCR.
> But none of those three are SPRs.  Please don't pollute that namespace.
> Put such defines into some fadump header, instead?

Sure, Segher.
I will stick with adding the defines in fadump header for the missing regs..



More information about the Linuxppc-dev mailing list