[RFC PATCH 1/3] powernv/mce: reduce mce console logs to lesser lines.

Michael Ellerman mpe at ellerman.id.au
Sun Mar 31 20:55:05 AEDT 2019


Mahesh Jagannath Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
> On 3/29/19 5:50 AM, Michael Ellerman wrote:
>> Hi Mahesh,
>> 
>> Thanks for doing this series.
>> 
>> Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
>>> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
>>>
>>> Also add cpu number while displaying mce log. This will help cleaner logs
>>> when mce hits on multiple cpus simultaneously.
>> 
>> Can you include some examples of the output before and after, so it's
>> easier to compare what the changes are.
...
>> 
>> I also think it'd be clearer to print the NIP on the 2nd line in all
>> cases, rather than the first.
>
> Sure, and I will then put "machine check" on 1st line like below ?
>
> printk("%sMCE: CPU%d: machine check (%s) %s %s %s %s[%s]\n",

Yes that would be good. Thanks.

cheers


More information about the Linuxppc-dev mailing list