[PATCH AUTOSEL 5.0 061/262] mm/resource: Return real error codes from walk failures

Sasha Levin sashal at kernel.org
Thu Mar 28 04:58:36 AEDT 2019

From: Dave Hansen <dave.hansen at linux.intel.com>

[ Upstream commit 5cd401ace914dc68556c6d2fcae0c349444d5f86 ]

walk_system_ram_range() can return an error code either becuase
*it* failed, or because the 'func' that it calls returned an
error.  The memory hotplug does the following:

	ret = walk_system_ram_range(..., func);
        if (ret)
		return ret;

and 'ret' makes it out to userspace, eventually.  The problem
s, walk_system_ram_range() failues that result from *it* failing
(as opposed to 'func') return -1.  That leads to a very odd
-EPERM (-1) return code out to userspace.

Make walk_system_ram_range() return -EINVAL for internal
failures to keep userspace less confused.

This return code is compatible with all the callers that I

Signed-off-by: Dave Hansen <dave.hansen at linux.intel.com>
Reviewed-by: Bjorn Helgaas <bhelgaas at google.com>
Acked-by: Michael Ellerman <mpe at ellerman.id.au> (powerpc)
Cc: Dan Williams <dan.j.williams at intel.com>
Cc: Dave Jiang <dave.jiang at intel.com>
Cc: Ross Zwisler <zwisler at kernel.org>
Cc: Vishal Verma <vishal.l.verma at intel.com>
Cc: Tom Lendacky <thomas.lendacky at amd.com>
Cc: Andrew Morton <akpm at linux-foundation.org>
Cc: Michal Hocko <mhocko at suse.com>
Cc: linux-nvdimm at lists.01.org
Cc: linux-kernel at vger.kernel.org
Cc: linux-mm at kvack.org
Cc: Huang Ying <ying.huang at intel.com>
Cc: Fengguang Wu <fengguang.wu at intel.com>
Cc: Borislav Petkov <bp at suse.de>
Cc: Yaowei Bai <baiyaowei at cmss.chinamobile.com>
Cc: Takashi Iwai <tiwai at suse.de>
Cc: Jerome Glisse <jglisse at redhat.com>
Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Cc: Paul Mackerras <paulus at samba.org>
Cc: linuxppc-dev at lists.ozlabs.org
Cc: Keith Busch <keith.busch at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: Sasha Levin <sashal at kernel.org>
 kernel/resource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 915c02e8e5dd..ca7ed5158cff 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -382,7 +382,7 @@ static int __walk_iomem_res_desc(resource_size_t start, resource_size_t end,
 				 int (*func)(struct resource *, void *))
 	struct resource res;
-	int ret = -1;
+	int ret = -EINVAL;
 	while (start < end &&
 	       !find_next_iomem_res(start, end, flags, desc, first_lvl, &res)) {
@@ -462,7 +462,7 @@ int walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
 	unsigned long flags;
 	struct resource res;
 	unsigned long pfn, end_pfn;
-	int ret = -1;
+	int ret = -EINVAL;
 	start = (u64) start_pfn << PAGE_SHIFT;
 	end = ((u64)(start_pfn + nr_pages) << PAGE_SHIFT) - 1;

More information about the Linuxppc-dev mailing list