[PATCH] powerpc: Make some functions static

Michael Ellerman mpe at ellerman.id.au
Wed Mar 20 23:52:53 AEDT 2019

Mathieu Malaterre <malat at debian.org> writes:
> On Tue, Mar 12, 2019 at 10:14 PM Christophe Leroy
> <christophe.leroy at c-s.fr> wrote:
>> Le 12/03/2019 à 21:31, Mathieu Malaterre a écrit :
>> > In commit cb9e4d10c448 ("[POWERPC] Add support for 750CL Holly board")
>> > new functions were added. Since these functions can be made static,
>> > make it so. While doing so, it turns out that holly_power_off and
>> > holly_halt are unused, so remove them.
>> I would have said 'since these functions are only used in this C file,
>> make them static'.
>> I think this could be split in two patches:
>> 1/ Remove unused functions, ie holly_halt() and holly_power_off().
>> 2/ Make the other ones static.
> Michael do you want two patches ?

That would be better if it's not too much trouble. A patch with a title
of "Make some functions static" shouldn't really be deleting functions


More information about the Linuxppc-dev mailing list