[PATCH v2 22/45] drivers: tty: serial: altera_uart: use devm_* functions
Enrico Weigelt, metux IT consult
info at metux.net
Fri Mar 15 09:33:52 AEDT 2019
Use the safer devm versions of memory mapping functions.
The iounmap() call isn't necessary anymore, as devm will clean up.
Signed-off-by: Enrico Weigelt, metux IT consult <info at metux.net>
---
drivers/tty/serial/altera_uart.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/altera_uart.c b/drivers/tty/serial/altera_uart.c
index 0e487ce..d4f7150 100644
--- a/drivers/tty/serial/altera_uart.c
+++ b/drivers/tty/serial/altera_uart.c
@@ -595,7 +595,9 @@ static int altera_uart_probe(struct platform_device *pdev)
return ret;
}
- port->membase = ioremap(port->mapbase, ALTERA_UART_SIZE);
+ port->membase = devm_ioremap(port->dev,
+ port->mapbase,
+ ALTERA_UART_SIZE);
if (!port->membase)
return -ENOMEM;
@@ -625,7 +627,6 @@ static int altera_uart_remove(struct platform_device *pdev)
if (port) {
uart_remove_one_port(&altera_uart_driver, port);
port->mapbase = 0;
- iounmap(port->membase);
}
return 0;
--
1.9.1
More information about the Linuxppc-dev
mailing list